Re: [PATCH 1/2] gitk: refresh the colour scheme

From: Andrej Shadura <andrew.shadura@collabora.co.uk>
Date: Mar 4, 2019, 09:35 UTC
Message-ID: <7e696805-4b80-cd26-aaaa-261a05ead964@collabora.co.uk>
In-Reply-To: <20190302230228.GA26937@blackberry>

On 03/03/2019 00:02, Paul Mackerras wrote:

Show 13 quoted lines

> On Tue, Feb 26, 2019 at 12:05:34PM +0100, Andrej Shadura wrote:
>> The colours gitk is currently using are from the basic 16 colour
>> palette, and are a bit too intensive to be comfortable or pleasant
>> to work with.
>>
>> Adjust the main colours (commit nodes, remotes, tags and one branch
>> colour) to be slightly softer.
>>
>> Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
> 
> Thanks for the patch, but I disagree.  I do like the change you made
> to the tag colours, but the blue you have for the commit node circles
> is pretty blah.  That needs a more definite colour.

I see.

1) Would you accept the patch without that change?
2) What colour would you prefer (except the already existing one)?

> Also, the "too intensive to be comfortable or pleasant" in the commit
> message reflect a personal preference, and the way it is put seems to
> me to be too intensive to be comfortable or pleasant.

Hmm, sorry if that came across not the way I intended. I was trying to formulate the thought in a way that would not be emotional or subjective, but I guess the end result was exactly opposite.

-- 
Cheers,
  Andrej