Re: [Outreachy PATCH v6 1/3] environment: stop storing `core.attributesFile` globally

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Feb 12, 2026, 10:33 UTC
Message-ID: <7d9e0e9b-4565-492c-81b7-2471a916015e@gmail.com>
In-Reply-To: <xmqq5x83w7m1.fsf@gitster.g>

On 11/02/2026 16:46, Junio C Hamano wrote:

Show 7 quoted lines

> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
> At the beginning of repo_config_values() in the patch, there is a
> check to ensure that repo->initialized is true and otherwise you get
> an error.  But the initialization is already done in the early part
> of initialize_repository() as quoted above.  So I do not see what
> difference it would make if we rewrote the last line as

In Bello's patch there is a second assertion in repo_config_values() that checks "repo == the_repository" and that one fails. I suggested adding it because the config values are still global rather than per repository so we should only be reading them from "the_repository".

Thanks

Phillip

> 	repo_config_values_init(&repo->config_values_private_);
> 
> I am confused.
>