Re: [PATCH] revision: mark blobs needed for resolve-undo as reachable

From: Derrick Stolee <derrickstolee@github.com>
Date: Jun 13, 2022, 15:15 UTC
Message-ID: <7cd41846-e6ef-7a24-0426-6031a529360f@github.com>
In-Reply-To: <xmqqfskdieqz.fsf@gitster.g>

On 6/9/2022 7:44 PM, Junio C Hamano wrote:

Show 6 quoted lines

> +	struct string_list *resolve_undo = istate->resolve_undo;
> +
> +	if (!resolve_undo)
> +		return 0;
> +
> +	for_each_string_list_item(item, resolve_undo) {

I see this is necessary since for_each_string_list_item() does
not handle NULL lists. After attempting to allow it to handle
NULL lists, I see that the compiler complains about the cases
where it would _never_ be NULL, so that change appears to be
impossible.
 
The patch looks good. I liked the comments for the three phases
of the test.

Thanks, -Stolee