Re: feature request: .blameignore

From: Barret Rhoden <brho@google.com>
Date: Apr 16, 2019, 14:52 UTC
Message-ID: <7cb3e28d-2f4a-9fa8-d3c5-3b9184e53149@google.com>
In-Reply-To: <5df051ce-007c-cc12-6f02-345b33480c0a@nerdocs.at>

Hi -

On 4/15/19 5:56 PM, Christian González wrote:

Show 16 quoted lines

> Am 15.04.19 um 23:15 schrieb Thomas Gummerer:
>> This sounds roughly like what Barret Rhoden (added to Cc) has been
>> working on.  I haven't followed that patch series in detail, but you
>> can have a look at it atthe latest iteration at
>> https://public-inbox.org/git/20190410162409.117264-1-brho@google.com/.
> 
> As far as I can see this is an "automagic" way of creating those "blame
> skips" - which can be easier in some way, but until it works "perfect"
> It is prone to produce problems IMHO.
> 
> The git history is a "document" that _has_ not to be changed by design.
> So if this "heuristic" produces a wrong result, it's kind of
> unpredictable what was wrong.
> 
> I think it would be MUCH easier to mark chunks or whole commits as  "not
> important" explicitly - by using a file.

I think there's a slight misunderstanding. In the patchset that Michael and I are working on, the user specifies whole commits explicitly. This is usually done with a file, but can also be done from the command line for "one-off" ignored commits. That sounds like what you want.

The heuristics come in when we try to pass blame for specific *lines* that an ignored commit touched. We pass the blame to the parent commit, but we also want to match the lines to a specific line in the parent commit. That way we can find the 'right' ancestor commmit. We're not able to always identify the 'right' commit, hence the heuristics.

Barret