git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Eliminate extraneous ref log entries

From
Kyle J. McKay <mackyle@gmail.com>
Date
Jan 30, 2021, 10:19 UTC
Message-ID
<7c7e8679f2da7e1475606d698b2da8c@72481c9465c8b2c4aaff8b77ab5e23c>

Since Git version v2.29.0, the `git symbolic-ref` command has started adding extraneous entries to the ref log of the symbolic ref it's updating.

This change was inadvertently introduced in commit 523fa69c36744ae6 ("reflog: cleanse messages in the refs.c layer", 2020-07-10, v2.29.0).

A bug report [1] was made about a failing test in the TopGit test suite. Further investigations into the cause led to this patch set.

1/2 - adds new tests to monitor this behavior 2/2 - corrects the problem

The tests added in 1/2 are marked `test_expect_failure` and then changed to `test_expect_success` in 2/2.

-Kyle
[1]: <https://github.com/mackyle/topgit/issues/17>
Kyle J. McKay (2):
  t/t1417: test symbolic-ref effects on ref logs
  refs.c: avoid creating extra unwanted reflog entries
 refs.c                   | 16 +++----
 t/t1417-reflog-symref.sh | 91 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 100 insertions(+), 7 deletions(-)
 create mode 100755 t/t1417-reflog-symref.sh
Next: Kyle J. McKay
Message 1 of 9 in “Eliminate extraneous ref log entries”
  1. 0/2 Eliminate extraneous ref log entriesKyle J. McKay, Jan 30, 2021
  2. 2/2 refs.c: avoid creating extra unwanted reflog entriesKyle J. McKay, Jan 30, 2021
  3. 1/2 t/t1417: test symbolic-ref effects on ref logsKyle J. McKay, Jan 30, 2021
  4. Junio C HamanoJan 30, 2021
  5. Kyle J. McKayJan 30, 2021
  6. Junio C HamanoJan 30, 2021
  7. Han-Wen NienhuysFeb 1, 2021
  8. Kyle J. McKayJan 30, 2021
  9. Junio C HamanoJan 31, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.