Re: [JGIT PATCH] Force maven build to assume UTF-8 encoded source files

From: Imran M Yousuf <imyousuf@gmail.com>
Date: Sep 9, 2008, 02:05 UTC
Message-ID: <7bfdc29a0809081905o30951d93lb8005f75d31b6002@mail.gmail.com>
In-Reply-To: <1220903169-15190-1-git-send-email-robin.rosenberg@dewire.com>

On Tue, Sep 9, 2008 at 1:46 AM, Robin Rosenberg <robin.rosenberg@dewire.com> wrote:

Show 7 quoted lines

> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> ---
>  jgit-maven/jgit/pom.xml |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> We had one unit test failing because of this.
>

Firstly thanks for the change, secondly sorry for the inconvenience. Thirdly, I could not detect the issue because the tests were passing in my end from Eclipse and Maven :(. Sorry and thanks once again.

Cheers,

Imran

Show 18 quoted lines

> -- robin
>
> diff --git a/jgit-maven/jgit/pom.xml b/jgit-maven/jgit/pom.xml
> index fe9b0c5..8ea56ca 100644
> --- a/jgit-maven/jgit/pom.xml
> +++ b/jgit-maven/jgit/pom.xml
> @@ -155,6 +155,7 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>                 <configuration>
>                     <source>1.5</source>
>                     <target>1.5</target>
> +                   <encoding>UTF-8</encoding>
>                 </configuration>
>             </plugin>
>         </plugins>
> --
> 1.6.0.1.267.gec3a
>
>

-- 
Imran M Yousuf
Email: imran@smartitengineering.com
Blog: http://imyousuf-tech.blogs.smartitengineering.com/
Mobile: +880-1711402557