git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] t1308-config-set: fix a test that has a typo

From
Tanay Abhra via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 10, 2019, 12:35 UTC
Message-ID
<7b88e36723e3e6d51118d62211f487b497c532cc.1570710932.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.387.git.gitgitgadget@gmail.com>
From: Tanay Abhra <tanayabh@gmail.com>

Change test 'find value_list for a key from a configset' to redirect the result to 'expect' instead of 'except' which was a typo.

With this change, the test case actually fails because it uses `configset_get_value`. Clearly, this was intended to be `configset_get_value_multi` since the test expects a list of values instead of a single value, so let's fix that, too.

Originally contributed as https://github.com/git/git/pull/451.
Signed-off-by: Tanay Abhra <tanayabh@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t1308-config-set.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
index d0a2727b85..7b4e1a63eb 100755
--- a/t/t1308-config-set.sh
+++ b/t/t1308-config-set.sh
@@ -166,14 +166,14 @@ test_expect_success 'find value with highest priority from a configset' '
 '
 
 test_expect_success 'find value_list for a key from a configset' '
-	cat >except <<-\EOF &&
+	cat >expect <<-\EOF &&
+	lama
+	ball
 	sam
 	bat
 	hask
-	lama
-	ball
 	EOF
-	test-tool config configset_get_value case.baz config2 .git/config >actual &&
+	test-tool config configset_get_value_multi case.baz config2 .git/config >actual &&
 	test_cmp expect actual
 '
 
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin
Message 2 of 4 in “t1308-config-set: fix a test that has a typo”
  1. 0/1 t1308-config-set: fix a test that has a typoJohannes Schindelin via GitGitGadget, Oct 10, 2019
  2. 1/1 t1308-config-set: fix a test that has a typoTanay Abhra via GitGitGadget, Oct 10, 2019
  3. Johannes SchindelinOct 10, 2019
  4. Junio C HamanoOct 11, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.