git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git Feature Request (Fixdown in interactive rebase)

From
Johannes Sixt <j6t@kdbg.org>
Date
Dec 24, 2020, 22:54 UTC
Message-ID
<7b5ad849-ca6c-a462-fdef-c06f8511d946@kdbg.org>
In-Reply-To
<xmqq8s9m3kx4.fsf@gitster.c.googlers.com>
Am 24.12.20 um 23:21 schrieb Junio C Hamano:
Show 9 quoted lines
> I wonder if we deliberately designed how each insn you can write in
> the todo list should come up with the authorship data (i.e. ident
> and timestamp), or if we are just using the natural consequence of
> how the implementation happens to work?  I think it makes sense for
> "fixup", as an instruction used to make a small tweak to the bulk of
> work you've done some time ago, to use the authorship information of
> the original commit that gets fixed up. I don't know offhand what
> other insns like "edit", "reword", etc. do, and if there is a room
> to improve them.

For 'squash' it was a deliberate decision to keep authorship of the first commit, see 81ab1cb43a87. Initially, 'edit' changed authorship including the date to the current author and date; that was changed to preserve them, but I cannot find the responsible commit.

-- Hannes
Previous: Junio C HamanoNext: Johannes Schindelin
Message 8 of 10 in “Git Feature Request (Fixdown in interactive rebase)”
  1. Mike McLeanDec 23, 2020
  2. brian m. carlsonDec 23, 2020
  3. Mike McLeanDec 23, 2020
  4. Junio C HamanoDec 23, 2020
  5. Mike McLeanDec 24, 2020
  6. Johannes SixtDec 24, 2020
  7. Junio C HamanoDec 24, 2020
  8. Johannes SixtDec 24, 2020
  9. Johannes SchindelinJan 6, 2021
  10. Charvi MendirattaJan 27, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.