Re: Git Feature Request (Fixdown in interactive rebase)
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Dec 24, 2020, 22:54 UTC
- Message-ID
- <7b5ad849-ca6c-a462-fdef-c06f8511d946@kdbg.org>
- In-Reply-To
- <xmqq8s9m3kx4.fsf@gitster.c.googlers.com>
Am 24.12.20 um 23:21 schrieb Junio C Hamano:
Show 9 quoted lines
> I wonder if we deliberately designed how each insn you can write in > the todo list should come up with the authorship data (i.e. ident > and timestamp), or if we are just using the natural consequence of > how the implementation happens to work? I think it makes sense for > "fixup", as an instruction used to make a small tweak to the bulk of > work you've done some time ago, to use the authorship information of > the original commit that gets fixed up. I don't know offhand what > other insns like "edit", "reword", etc. do, and if there is a room > to improve them.
For 'squash' it was a deliberate decision to keep authorship of the first commit, see 81ab1cb43a87. Initially, 'edit' changed authorship including the date to the current author and date; that was changed to preserve them, but I cannot find the responsible commit.
-- Hannes