Re: [PATCH v2 0/5] Speed up remove_redundant()

From: Derrick Stolee <stolee@gmail.com>
Date: Feb 1, 2021, 15:48 UTC
Message-ID: <7a1a8990-59e7-d538-d382-446fdc270810@gmail.com>
In-Reply-To: <pull.852.v2.git.1612183647.gitgitgadget@gmail.com>

On 2/1/2021 7:47 AM, Derrick Stolee via GitGitGadget wrote:

Show 7 quoted lines

> My tests were on the Linux kernel repository, testing this command:
> 
>   git merge-base --independent $(git for-each-ref refs/tags --format="%(refname)")
> 
>        Before: 16.4s
> After Patch 1:  1.1s
> After Patch 2:  0.1s

During my testing of v2, I discovered how remove_redundant() is being used as part of 'git log --simplify-merges'. So, here are some performance numbers for the Linux kernel repository with a full commit-graph and changed-path Bloom filters running

  git log --oneline -n10 --simplify-merges -- kernel/

Benchmark #1: old
  Time (mean ± σ):      5.770 s ±  0.030 s    [User: 5.551 s, System: 0.219 s]
  Range (min … max):    5.728 s …  5.827 s    10 runs
 
Benchmark #2: new
  Time (mean ± σ):      5.030 s ±  0.017 s    [User: 4.805 s, System: 0.224 s]
  Range (min … max):    4.999 s …  5.054 s    10 runs
 
Summary
  'new' ran
    1.15 ± 0.01 times faster than 'old'

Thanks, -Stolee