git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] strbuf: retire strbuf_commented_lines()

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Oct 29, 2024, 20:53 UTC
Message-ID
<7a0520b4-2530-4660-a858-1def0c8d6de2@app.fastmail.com>
In-Reply-To
<20240912205301.1809355-3-gitster@pobox.com>
On Thu, Sep 12, 2024, at 22:53, Junio C Hamano wrote:
Show 7 quoted lines
> The API allows the caller to pass any string as the comment prefix,
> but in reality, everybody passes the comment_line_str from the
> environment.
>
> Replace this overly flexible API with strbuf_comment_lines() that
> does not allow customization of the comment_line_str (usually '#'
> but can be configured via the core.commentChar).
core.commentChar or core.commentString.
-- 
Kristoffer Haugsbakk
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 7 in “Simplify "commented" API functions”
  1. 0/2 Simplify "commented" API functionsJunio C Hamano, Sep 12, 2024
  2. 1/2 strbuf: retire strbuf_commented_addf()Junio C Hamano, Sep 12, 2024
  3. 2/2 strbuf: retire strbuf_commented_lines()Junio C Hamano, Sep 12, 2024
  4. Kristoffer HaugsbakkOct 29, 2024
  5. Junio C HamanoSep 12, 2024
  6. Patrick SteinhardtSep 13, 2024
  7. Junio C HamanoSep 13, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.