RE: [QGit] [PATCH] Modify Highlight Color at File Context View.

From: Li Frank-B20596 <frank.li@freescale.com>
Date: Oct 4, 2008, 14:32 UTC
Message-ID: <7FD1F85C96D70C4A89DA1DF7667EAE9607A45A@zch01exm23.fsl.freescale.net>
In-Reply-To: <e5bfff550810032319s57a0cd52m37aeb8d801019150@mail.gmail.com>

 
Marco:
	
	It is difference between my patch and you applied patch.

Git diff HEAD^
-	item->setForeground(b);
+		item->setForeground(fore);
+		item->setForeground(back);
 		item->setFont(f);

In my patch:

- item->setForeground(b); + item->setForeground(fore); + item->setBackground(back);

It should be setBackground(back), not setForeground(back);

Best regards Frank Li

-----Original Message-----
From: Marco Costalba [mailto:mcostalba@gmail.com] 
Sent: Saturday, October 04, 2008 2:20 PM
To: Li Frank-B20596
Cc: git@vger.kernel.org
Subject: Re: [QGit] [PATCH] Modify Highlight Color at File Context View.

On Wed, Oct 1, 2008 at 8:47 AM, Marco Costalba <mcostalba@gmail.com> wrote:

> On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596

<Frank.Li@freescale.com> wrote:

Show 13 quoted lines

>> Marco:
>>
>>          I don't get my patch by git-pull.
>>          There are not my patch at
>> http://git.kernel.org/?p=qgit/qgit4.git;a=summary.
>>
>> best regards
>> Frank Li
>> ________________________________
>
> I have pushed to my local repo, I will be able to push to public repo 
> only this week end.
>

Ok. Now is pushed to public repo.

Frank, are you sure it works? for me it does not seem to make any difference.

Marco