Re: git-gui ignores core.hooksPath
- From
Philip Oakley <philipoakley@iee.org>
- Date
- Jun 2, 2017, 23:00 UTC
- Message-ID
- <7B6DC5C9C2354BD9BB08DD84FF6628D1@PhilipOakley>
- In-Reply-To
- <CACBZZX6H4wxQ7hrO1Y1u6Qyr5gpK9GeCxpv-x2q3Eq2WCbkK8Q@mail.gmail.com>
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Show 27 quoted lines
> On Fri, Jun 2, 2017 at 3:41 PM, Philipp Gortan <philipp@gortan.org> wrote: >> Hi git devs, >> >> First off, thanks for your awesome work! >> >> I've been unhappy for quite a while that I had to configure the hooks >> manually for each of my repos - until I found out recently that there is >> the core.hooksPath config variable that (when set globally) allows me to >> specify a hooks directory to be used for all my repositories. >> >> Now I was happy - for a few minutes, until I tested this feature in >> git-gui, and realized that it doesn't work there. >> >> This seems to be caused by "proc githook_read", which says "set pchook >> [gitdir hooks $hook_name]" instead of querying "git config >> core.hooksPath" first - cf >> https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/git-gui/git-gui.sh#L627 >> >> Would be great if this could get fixed... > > Hi. I added core.hooksPath, glad to see it's useful to other people. > > This indeed is something that should be fixed, but git-gui development > is managed outside of git.git, it's just occasionally pulled in. I'm > not what the best place to contact is, but I've CC'd > Philip Oakley who's been making recent commits to git-gui.git at > http://repo.or.cz/git-gui.git/
The proper maintainer for the git-gui is Pat Thoyts (cc'd) who now has a repo at https://github.com/patthoyts/git-gui where Pull requests can be made, with patches posted here initially for wider review.
I'm just another contributor, but I have managed (with a bit of help from google and formative years using FORTH;-) to get a few git-gui patches tested and incorporated. tcl/tk isn't that hard, its just interpreted code.., the main part, for me, was working out how to ru the code in the Git-for-Windows SDK environment (with help). -- Philip