git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] diffcore-pickaxe.c: a void function shouldn't try to return something

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Oct 4, 2010, 22:51 UTC
Message-ID
<7B67fI3-KUXNMcC63_TwzWm3yMw3MBsO-UId6DCtnNEi0B_PuBGQVjh0xBHrwD3jb3ptTcw5d38@cipher.nrlssc.navy.mil>
In-Reply-To
<7B67fI3-KUXNMcC63_TwzSz0R5IrKAQx1Xuml4Po0PYEJroaM3Kd71QYcXsJK6NsImqnd3Sd4t0@cipher.nrlssc.navy.mil>
From: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 diffcore-pickaxe.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c
index 3857099..ea03b91 100644
--- a/diffcore-pickaxe.c
+++ b/diffcore-pickaxe.c
@@ -281,7 +281,7 @@ void diffcore_pickaxe(struct diff_options *o)
 {
 	/* Might want to warn when both S and G are on; I don't care... */
 	if (o->pickaxe_opts & DIFF_PICKAXE_KIND_G)
-		return diffcore_pickaxe_grep(o);
+		diffcore_pickaxe_grep(o);
 	else
-		return diffcore_pickaxe_count(o);
+		diffcore_pickaxe_count(o);
 }
-- 
1.7.3.1
Previous: Brandon Casey
Message 2 of 2 in “diffcore-pickaxe.c: remove unnecessary curly braces”
  1. 1/2 diffcore-pickaxe.c: remove unnecessary curly bracesBrandon Casey, Oct 4, 2010
  2. 2/2 diffcore-pickaxe.c: a void function shouldn't try to return somethingBrandon Casey, Oct 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.