[PATCH 1/2] t1300: demonstrate that CamelCased aliases regressed
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 14, 2017, 08:39 UTC
- Message-ID
- <79af768e29d878da995df553638b18fc6d7a5190.1500021526.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1500021526.git.johannes.schindelin@gmx.de>
It is totally legitimate to add CamelCased aliases, but due to the way config keys are compared, the case does not matter.
Except that now it does: the alias name is expected to be all lower-case. This is a regression introduced by a9bcf6586d1 (alias: use the early config machinery to expand aliases, 2017-06-14).
Noticed by Alejandro Pauly, diagnosed by Kevin Willford.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- t/t1300-repo-config.sh | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh index a37ef042221..0df71b84ccf 100755 --- a/t/t1300-repo-config.sh +++ b/t/t1300-repo-config.sh @@ -1075,6 +1075,13 @@ test_expect_success 'git -c works with aliases of builtins' ' test_cmp expect actual ' +test_expect_failure 'aliases can be CamelCased' ' + test_config alias.CamelCased "rev-parse HEAD" && + git CamelCased >out && + git rev-parse HEAD >expect && + test_cmp expect out +' + test_expect_success 'git -c does not split values on equals' ' echo "value with = in it" >expect && git -c core.foo="value with = in it" config core.foo >actual &&
-- 2.13.3.windows.1.13.gaf0c2223da0