git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] t4014: invoke format-patch with --stdout where intended

From
Thomas Rast <trast@student.ethz.ch>
Date
Aug 29, 2011, 20:10 UTC
Message-ID
<797b96d784211a9d26eac1a5f5f7f0388a2c6a3b.1314648438.git.trast@student.ethz.ch>
In-Reply-To
<bbfb7190ca0125798417f57f4d33b5443257e478.1314648438.git.trast@student.ethz.ch>

The test wrote something along the lines of 0001-foo.patch to output, which of course never contained a signature. Luckily the tested behaviour is actually present.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
 t/t4014-format-patch.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index b4d4207..a45d4fb 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -698,8 +698,8 @@ test_expect_success 'format-patch --no-signature supresses signatures' '
 	! grep "^-- \$" output
 '
 
-test_expect_failure 'format-patch --signature="" supresses signatures' '
-	git format-patch --signature="" -1 >output &&
+test_expect_success 'format-patch --signature="" supresses signatures' '
+	git format-patch --stdout --signature="" -1 >output &&
 	check_patch output &&
 	! grep "^-- \$" output
 '
-- 
1.7.7.rc0.370.gdcae57
Previous: Thomas RastNext: Thomas Rast
Message 2 of 5 in “t4014: check for empty files from git format-patch --stdout”
  1. 1/4 t4014: check for empty files from git format-patch --stdoutThomas Rast, Aug 29, 2011
  2. 2/4 t4014: invoke format-patch with --stdout where intendedThomas Rast, Aug 29, 2011
  3. 3/4 t4014: "no-add-headers" is actually called "no-add-header"Thomas Rast, Aug 29, 2011
  4. 4/4 Document negated forms of format-patch --to --cc --add-headersThomas Rast, Aug 29, 2011
  5. Junio C HamanoAug 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.