git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bash completion: Add completion for 'git grep'

From
Lee Marlow <lee.marlow@gmail.com>
Date
Aug 3, 2008, 07:31 UTC
Message-ID
<7968d7490808030031v39726af6r9f88feb28df02de7@mail.gmail.com>
In-Reply-To
<20080802210525.GD24723@spearce.org>
On Sat, Aug 2, 2008 at 3:05 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 9 quoted lines
>
> Hmm.  The has_doubledash test seems redundant since we don't do
> anything with args that aren't --foo.  Even though git-grep will
> accept a tree-ish and thus completion of __git_refs here may
> make sense.
>
> But that is very much a user question.  Do users mostly search a
> file in the current working directory, or do they mostly search
> a tree-ish?

I haven't found myself using grep to search anything but the current working directory. I wonder whether __git_complete_file would be better than __git_refs. My issue with __git_complete_file in this case and also doing completion for 'git mv' is that it falls back to just __git_refs. Would it be better if it fell back to __git_refs and ls-tree for HEAD? That way when using completion to get to Documentation/git-grep.txt, it doesn't also show completions for Documentation/git-grep.{1,html,xml}.

-Lee
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 7 in “bash completion: Add completion for 'git grep'”
  1. bash completion: Add completion for 'git grep'Lee Marlow, Aug 2, 2008
  2. Shawn O. PearceAug 2, 2008
  3. Lee MarlowAug 3, 2008
  4. Shawn O. PearceAug 4, 2008
  5. bash completion: Add completion for 'git grep'Lee Marlow, Aug 4, 2008
  6. Shawn O. PearceAug 4, 2008
  7. Shawn O. PearceAug 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.