Re: [RFC] Generation Number v2
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Oct 29, 2018, 20:06 UTC
- Message-ID
- <78882b71-09b2-cb4a-4285-5aa7b61907fe@gmail.com>
- In-Reply-To
- <CAGZ79ka-FTqaXdrMixjUp2THJ3L0YvEnkKxs3XFgB3WEEy2-Tg@mail.gmail.com>
On 10/29/2018 3:22 PM, Stefan Beller wrote:
Show 18 quoted lines
>> Based on the performance results alone, we should remove minimum >> generation numbers, (epoch, date) pairs, and FELINE index from >> consideration. There are enough examples of these indexes performing >> poorly. >> >> In contrast, maximum generation numbers and corrected commit >> dates both performed quite well. They are frequently the top >> two performing indexes, and rarely significantly different. >> >> The trade-off here now seems to be: which _property_ is more important, >> locally-computable or backwards-compatible? >> >> * Maximum generation number is backwards-compatible but not >> locally-computable or immutable. > These maximum generation numbers sound like the reverse of > the generation numbers as they are currently implemented, i.e. > we count all commits between the commit A and all heads. > How would this impact creation of a commit?
The indexes listed here would be computed at the same time as a commit-graph (and only change on commit-graph writes).
This idea of having something depend on the "global state" isn't ideal (in my opinion) but it certainly works for the tests specified below.
> The current generation numbers can be lazily updated or not > updated at all. In my understanding of the maximum generation > numbers, a new commit would make these maximum generation > numbers invalid (i.e. they have to be recomputed).
New commits would change the value you would get by the definition (on rewrite of the commit-graph) but don't violate the reachability index property (maxgen(A) < maxgen(B) => A can't reach B). So that doesn't effect their usefulness.
> Are there ways out by deferring the computation of maximum > generation numbers while still being able to work with some > commits that are un-accounted for?
Creating a commit that doesn't exist in the commit-graph file results in a commit with generation number INFINITY. The new commits can't be reached by commits with finite generation number.
Show 12 quoted lines
> When recomputing these numbers, the current generation number > (V0) has the property that already existing numbers can be re-used > as-is. We only need to compute the numbers for new commits, > and then insert this to the appropriate data structures (which is > a separate problem, one could imagine a split generation > numbers file like the split index) > > For the V2 maximum generation numbers, would we need to > rewrite the numbers for all commits once we recompute them? > Assuming that is true, it sounds like the benchmark doesn't > cover the whole costs associated with V2, which is why the > exceptional performance can be explained.
You're right, we need to recompute the entire list of maximum generation number values. However, you are a bit hung up on "maxgen" being a fixed function that is correct at all times. We could compute the "maxgen" for the set of commits that are written to the "split" commit-graph while leaving the base the same. There is one tricky part here: we need to initialize the values starting at "num commits in the combined commit-graph" (commits in the base and split portion). The minimum possible value in the split portion will be larger than the maximum possible value in the base portion. Since the (future) implementation of split commit-graphs would have all commit-parent edges pointing down into the base and not from the base into the split, this will continue to satisfy our reachability index property.
As for the cost: we need to do a topo-order walk and then a quick minimum-value check across all parents. This is O(N), and the constant is small. This may be a cost worth paying.
> (Note: The table as read in > https://public-inbox.org/git/6367e30a-1b3a-4fe9-611b-d931f51effef@gmail.com/ > seems line broken, using gmails web interface is not good > for ASCII art and patches, git-send-email would fare better)
Sorry for that. I copy-pasted into Thunderbird. Hopefully most users can redirect to the GitHub-rendered markdown if they have trouble.
Show 11 quoted lines
> >> * Corrected commit-date is locally-computable and immutable, >> but not backwards-compatible. > How are these dates not backwards incompatible? > We don't have to expose these dates to the user, but > - just like generation numbers - could store them and use them > but not tell the user about it. > > We would need to be really careful to not expose them at all > as they look like the real dates, so that could make for an > awkward bug report.
By "backwards-compatible" I mean that we could store them in the commit-graph file without breaking existing clients (or by introducing extra data).
We could easily add these corrected commit dates as an optional chunk, but that adds 8 bytes per commit, and we already use 8 bytes for the (generation, date) pairs.
The solution I made in my prototype is to replace the generation number with an offset for how much to add to the commit-date to get the corrected commit-date. However, an old client would interpret these offsets as generations and have incorrect output.
A potential way to get around this is to consider the pair (offset, date) and define the offset(C) to be the minimum of min { offset(P), date(P) - date(C) }. This would satisfy the requirements for the V0 reachability index. I'm making a note to implement _this_ version and give it a test.
Show 12 quoted lines
> > The approach of "corrected commit date" sounds like we could > have a very lazy approach, i.e. no extra data structures needed > for many commits (as the corrected date equals the real date) > and only need to store the corrections for some commits. > Such an approach however would not make it easy to know > if we operate on corrected dates, or if we even checked them > for correctness before. > > So if we'd have an additional row in the generation numbers file > telling the corrected date, then we should be able to be backwards > compatible?
Yeah, an optional chunk with the corrected date would work, but be wasteful.
Thanks, -Stolee