Re: [PATCHv2 2/2] completion: complete config variables for --get/getall/unset/unset-all

From: Stephen Boyd <bebarino@gmail.com>
Date: May 13, 2009, 18:50 UTC
Message-ID: <780e0a6b0905131150q30e0bcacrff69cd78cd96ff34@mail.gmail.com>
In-Reply-To: <7vtz3o4zu2.fsf@alter.siamese.dyndns.org>

On Wed, May 13, 2009 at 11:33 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 27 quoted lines

> Stephen Boyd <bebarino@gmail.com> writes:
>
>>>> Subject: completion: complete config variables for
>>>> --get/getall/unset/unset-all
>>>
>>> Hmm, shouldn't this just be
>>>
>>>    Subject: completion: complete variable names for "git config" command
>>>
>>> ?
>>>
>>
>> This patch adds completion for set variable names when --get,
>> --get-all, --set, or --set-all has been specified. Completion of
>> variable names for git config already exists. Maybe this would be more
>> clear:
>>
>> Subject: completion: complete set variable names for git config
>> --get/get-all/set-set-all
>
> Actually I was shooting for shorter description.  It is more like
>
>        bash: complete variable names for "git config" with options
>
> perhaps?
>
>

Heh, ok. This sounds fine.