Re: [PATCH 3/3] completion: use specified file (if any) when completing config vars
- From
Stephen Boyd <bebarino@gmail.com>
- Date
- May 7, 2009, 19:55 UTC
- Message-ID
- <780e0a6b0905071255g4ade6316oace6a2be6a6d2@mail.gmail.com>
- In-Reply-To
- <20090507151207.GQ30527@spearce.org>
On Thu, May 7, 2009 at 8:12 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 12 quoted lines
> Stephen Boyd <bebarino@gmail.com> wrote: >> Only list the variables that can actually be affected by the command by >> searching the arguments for a config file setting. > > Wow, this is a lot of magic. > > Try: > > git config --global remote.gitster.url $(git config remote.o<TAB> > > You'll complete against --global, not the local repository. >
Yeah, I didn't think it would be very robust. Is it a good idea to keep going down this path, or is it too magical? This example could be fixed by searching the words backwards, but I imagine there is some other case where that will fail. Also, --global and --system don't have values, so right now it's all wrong (i.e. config_file is "--global remote.gitster.url" for this example).