Re: [PATCH] show-branch: color the commit status signs

From: Stephen Boyd <bebarino@gmail.com>
Date: Apr 22, 2009, 19:26 UTC
Message-ID: <780e0a6b0904221226s43a40a12k8bf83de12fa7815d@mail.gmail.com>
In-Reply-To: <1240350779-9686-1-git-send-email-markus.heidelberg@web.de>

On Tue, Apr 21, 2009, Markus Heidelberg <markus.heidelberg@web.de> wrote:

> +--color::
> +       Color the status sign of the commits. Each branch uses a single color.

I don't know what the status sign of a commit is without reading your commit message. Maybe reword this to be:

Color the status sign ('*' '!' '+' '-') of each commit corresponding to the branch it's in.

Show 10 quoted lines

> +static char column_colors[][COLOR_MAXLEN] = {
> +       GIT_COLOR_RED,
> +       GIT_COLOR_GREEN,
> +       GIT_COLOR_YELLOW,
> +       GIT_COLOR_BLUE,
> +       GIT_COLOR_MAGENTA,
> +       GIT_COLOR_CYAN,
> +};
> +
> +#define COLUMN_COLORS_MAX (ARRAY_SIZE(column_colors))

This looks like a copy/paste (with a small edit) from graph.c so maybe you want to refactor the original code from graph.c to color.h?