Re: [PATCH (amend)] gitweb: Slight visual improvements to commitdiff view

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Oct 27, 2006, 00:39 UTC
Message-ID: <780488.44315.qm@web31803.mail.mud.yahoo.com>
In-Reply-To: <200610270150.40100.jnareb@gmail.com>

--- Jakub Narebski <jnareb@gmail.com> wrote:

Show 17 quoted lines

> First, I have removed creating empty divs. The div with number of 
> changed files in git_difftree_body is added only if the message about 
> number of changed files is displayed (above 10).
> 
> Second, I have moved commit message body in commitdiff outside 
> "page_body" div, to be together with "author_date" div with authorship 
> info. The name of class was changed from "log" to more informative 
> "commitdiff_log". This required some changes and additions to CSS. Now 
> "commitdiff_log" div is responsible for displaying line separatring it 
> from "page_body".
> 
> I have added not full line above "patchset" div (between patchet and 
> difftree). It is added by "patchset" div and separated by 8px padding.
> 
> 
> Those changes might wait for proper refactoring of gitweb CSS (having 
> for example 8px padding in one place only).

Excellent! I'd like this explanation to be part of the commit message if that patchset is committed to git.git.

    Luben