Re: [PATCH] delta-islands: respect progress flag

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 20, 2019, 12:42 UTC
Message-ID: <77c41405-2270-1a48-2277-533f26ac1530@gmail.com>
In-Reply-To: <20190620085832.GA5039@sigill.intra.peff.net>

On 6/20/2019 4:58 AM, Jeff King wrote:

Show 13 quoted lines

> The delta island code always prints "Marked %d islands", even if
> progress has been suppressed with --no-progress or by sending stderr to
> a non-tty.
> 
> Let's pass a progress boolean to load_delta_islands(). We already do
> the same thing for the progress meter in resolve_tree_islands().
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Arguably this should be a real progress meter that counts up, but I'm
> not sure what it should be counting. Refs we analyzed? Islands found?
> Unless you have a ton of refs, it doesn't really matter, so I just
> punted on that part for now and only fixed the egregious bug. :)

I agree that the first goal should be to stop writing 'progress' output to stderr when progress is disabled. Changing this to a full progress indicator can be done on top of this patch later (without changing the method prototypes again) if desired.

LGTM. -Stolee