Re: [PATCH 08/12] pack-write: switch various SHA-1 values to abstract forms

From: Patryk Obara <patryk.obara@gmail.com>
Date: Jan 28, 2018, 20:30 UTC
Message-ID: <76f6c291-9c48-279d-3bb6-fc42a8e0eb9b@gmail.com>
In-Reply-To: <20180128155722.880805-9-sandals@crustytoothpaste.net>

On 28/01/2018 16:57, brian m. carlson wrote:

Show 7 quoted lines

>   		if (partial_pack_offset == 0) {
> -			unsigned char sha1[20];
> -			git_SHA1_Final(sha1, &old_sha1_ctx);
> -			if (hashcmp(sha1, partial_pack_sha1) != 0)
> +			unsigned char hash[GIT_MAX_RAWSZ];
> +			the_hash_algo->final_fn(hash, &old_hash_ctx);
> +			if (hashcmp(hash, partial_pack_hash) != 0)

Maybe "hash" should be struct object_id here?

Show 5 quoted lines

>   char *index_pack_lockfile(int ip_out)
>   {
> -	char packname[46];
> +	char packname[GIT_MAX_HEXSZ + 6];
> +	int len = the_hash_algo->hexsz + 6;

Just me nitpicking, but "len" can be const :)

-- 
| ← Ceci n'est pas une pipe
Patryk Obara