Re: [PATCH] git-send-email: parse all messages in mbox

From: Jay Soffian <jaysoffian@gmail.com>
Date: May 14, 2009, 14:48 UTC
Message-ID: <76718490905140748n390d0e85t8349b69fc6debc2a@mail.gmail.com>
In-Reply-To: <873abbeoqc.wl%vmayatsk@redhat.com>

On Mon, May 11, 2009 at 9:46 AM, Vitaly Mayatskikh <v.mayatskih@gmail.com> wrote:

> Currently git-send-email sends all mbox in one email. This seems to be wrong,
> because mbox can contain several messages. For example,
> `git format-patch --stdout' forms mbox file with all patches in it.

Just out of curiosity, what is the motivation for this patch?

By default, format-patch generates a file per commit, which is what send-email currently expects. You can also specify one or more commits to send-email directly, in which case it runs format-patch on your behalf. And, send-email cannot handle messages on stdin, so "git format-patch | git send-email" is not a valid workflow, even after this patch.

So the only way I can see this being useful is if you're doing something like:

$ git format-patch --stdout > mbox $ git send-email mbox

Or you can combine those in bash with:

$ git send-email <(git format-patch --stdout)

But, why? The only way this patch would make any sense to me is if it _also_ extended send-email to read its messages from stdin.

j.