Re: git send-email prompting too much

From: Jay Soffian <jaysoffian@gmail.com>
Date: Apr 5, 2009, 02:49 UTC
Message-ID: <76718490904041949w4b66d9ffkbf06299fbff22db9@mail.gmail.com>
In-Reply-To: <76718490904041913s2c769022t92ca194263e29eb0@mail.gmail.com>

On Sat, Apr 4, 2009 at 10:13 PM, Jay Soffian <jaysoffian@gmail.com> wrote:

> Wait. Did hitting just enter work in the past? Because I tested this
> before I made this commit and at least on my machine, hitting enter
> just presented the prompt again. So I retained that behavior.

Argh. I should read my own commit message. I claim:

    2) "Who should the emails be sent to?". Previously this prompt passed a
    second argument ("") to $term->readline() which was ignored. I believe
    the intent was to allow the user to just hit return. Now the user
    can do so, or type ctrl-d.

    3) "Message-ID to be used as In-Reply-To for the first email?".
    Previously this prompt passed a second argument (effectively undef) to
    $term->readline() which was ignored. I believe the intent was the same
    as for (2), to allow the user to just hit return. Now the user can do
    so, or type ctrl-d.

Clearly I broke something. Will send a patch shortly. :-(

j.