Re: [PATCH 0/5] Extend pattern refspecs

From

Jay Soffian <jaysoffian@gmail.com>

Date

Mar 6, 2009, 06:52 UTC

Message-ID

<76718490903052252y1778aa41g8f3e52329f7bf288@mail.gmail.com>

In-Reply-To

<alpine.LNX.1.00.0903060038510.19665@iabervon.org>

On Fri, Mar 6, 2009 at 1:07 AM, Daniel Barkalow <barkalow@iabervon.org> wrote:

> On Fri, 6 Mar 2009, Jay Soffian wrote:
>
> Actually, you should be able to just drop your "buf" and use spec->src and
> spec->dst, since it just stores the original strings. So that should be
> easy enough, although it might be good to go through a remote.c function
> just in case it becomes more complicated later. On the other hand,
> get_head_names() should probably get a patch like my 1/5 to have it use
> the remote.c parser, or should use a constant "head mirror" refspec like
> that tag_refspec already in remote.c

Okay.

> Do you have tests for "git remote show -n"?

Yes. Apparently not enough of them though if nothing is failing.

> Merging my series (on top of
> origin/master) and e5dcbfd and adding a final '*' to the string in
> get_head_names() made everything pass for me, without doing anything about
> the extra *s, but the output is clearly not quite right.

Hmm, alright.

> I'm not seeing anything that makes assumptions about the matching
> semantics of pattern refspecs, just stuff about how the stored form
> relates to the config-file form.

Okay, that sounds right.

j.