Re: [PATCH] branch: optionally setup branch.*.merge from upstream local branches

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 19, 2008, 13:49 UTC
Message-ID: <76718490802190549p549a34afo913efefebaf5fa97@mail.gmail.com>
In-Reply-To: <20080219074423.GA3982@steel.home>

On Feb 19, 2008 2:44 AM, Alex Riesen <raa.lkml@gmail.com> wrote:

Show 5 quoted lines

> Jay Soffian, Tue, Feb 19, 2008 03:07:12 +0100:
> > +enum branch_track {
> > +     BRANCH_TRACK_NEVER = 0,
>
> enums start at 0 anyway, don't they?

I don't know, but guys, give me a break on the enums already. What's the preferred syntax already because the existing code is not consistent:

enum color_branch {
	COLOR_BRANCH_RESET = 0,
	COLOR_BRANCH_PLAIN = 1,
	COLOR_BRANCH_REMOTE = 2,
	COLOR_BRANCH_LOCAL = 3,
	COLOR_BRANCH_CURRENT = 4,
};

enum {
	TAGS_UNSET = 0,
	TAGS_DEFAULT = 1,
	TAGS_SET = 2
};

enum update_mode { BOTH = 0, WORKING_DIRECTORY, INDEX } *modes;

enum exist_status {
	index_nonexistent = 0,
	index_directory,
	index_gitdir,
};

enum CAPABILITY {
	NOLOGIN = 0,
	UIDPLUS,
	LITERALPLUS,
	NAMESPACE,
};

j.