Re: [PATCH] branch: optionally setup branch.*.merge from upstream local branches

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 18, 2008, 14:38 UTC
Message-ID: <76718490802180638k6f776463t692a828f71ce0a58@mail.gmail.com>
In-Reply-To: <alpine.LSU.1.00.0802181403040.30505@racer.site>

On Feb 18, 2008 9:05 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 7 quoted lines

> Hi,
>
> On Mon, 18 Feb 2008, Jay Soffian wrote:
>
> >  Incorporated Johannes' second round of feedback.
>
> Not exactly.

Heh...

> This looks completely different than what I commented on.  And my comments
> suggested a different solution.

Thought process went like this:

- fix sprintf() to use snprintf()
- notice setup_tracking() uses sprintf() and think about fixing it too
- realize setup_tracking() does bounds checking first and its use of sprintf()
  is therefor safe.
- go to copy the bounds checking code from setup_tracking() to the area you
  commented on.
- realized duplicating the code was dumb and I could just re-use what was
  already in setup_tracking() via what was just sent.

> But you can use the time to write some tests ;-)

Sure I can. I really hope after all this work the patch gets accepted.

j.