diff --check line number bug
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Feb 15, 2008, 20:18 UTC
- Message-ID
- <76718490802151218s62c4f884u39353b66540b347a@mail.gmail.com>
% mkdir git-ws
% cd git-ws
% git init
% touch foo
% git add foo
% printf '\n\nline 3 \n\nline 5 \nline 6\n' > foo
% cat -n foo
1
2
3 line 3
4
5 line 5
6 line 6
% sed -ne l foo
$
$
line 3 $
$
line 5 $
line 6$
% git diff --check foo
foo:1: trailing whitespace.
+line 3
foo:2: trailing whitespace.
+line 5
% git version
git version 1.5.4.1.1281.g75dfApparently somewhere in the bowels of the "Crazy xdl interfaces", empty lines are skipped over, thus the line number counting in checkdiff_consume() is off? I dunno, I briefly looked into fixing it but it didn't seem like a quick fix.
j.