Re: [PATCH 1/4] git-compat-util.h: xsize_t() - avoid -Wsign-compare warnings

From: Torsten Bögershausen <tboegi@web.de>
Date: Sep 21, 2017, 18:49 UTC
Message-ID: <75416139-74c5-8a60-22e8-79c53dd062c1@web.de>
In-Reply-To: <15367a04-754c-f6b8-a89b-2c1ff65dedf5@ramsayjones.plus.com>

On 2017-09-21 18:46, Ramsay Jones wrote:

Show 21 quoted lines

> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  git-compat-util.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 9bc15b036..cedad4d58 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -898,9 +898,11 @@ static inline char *xstrdup_or_null(const char *str)
>  
>  static inline size_t xsize_t(off_t len)
>  {
> -	if (len > (size_t) len)
> +	size_t size = (size_t) len;
> +
> +	if (len != (off_t) size)
>  		die("Cannot handle files this big");
> -	return (size_t)len;
> +	return size;

Hm, can someone help me out ? Why is the cast not needed ?

>  }
>  
>  __attribute__((format (printf, 3, 4)))
>