git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] backfill: default to grabbing edge blobs too

From
Derrick Stolee <stolee@gmail.com>
Date
Apr 16, 2026, 14:15 UTC
Message-ID
<74af0a09-4c1b-4c0a-b5b3-e5044fcd0aaa@gmail.com>
In-Reply-To
<607ed38e2a8ae94266b4a3d51610e604cca8df4f.1776297482.git.gitgitgadget@gmail.com>
On 4/15/2026 7:58 PM, Elijah Newren via GitGitGadget wrote:
> From: Elijah Newren <newren@gmail.com>
> Add an extra --[no-]include-edges flag to allow grabbing blobs from
> edge commits.  Since the point of backfill is to prevent on-demand blob
> loading and these are common commands, default to --include-edges.
I like this option and your motivation for including it.
Show 6 quoted lines
> @@ -116,6 +117,8 @@ static int do_backfill(struct backfill_context *ctx)
>  	/* Walk from HEAD if otherwise unspecified. */
>  	if (!ctx->revs.pending.nr)
>  		add_head_to_pending(&ctx->revs);
> +	if (ctx->include_edges)
> +		ctx->revs.edge_hint = 1;
This would still work if...
>  		.revs = REV_INFO_INIT,
> +		.include_edges = 1,
...this was initialized to -1 to allow for "no user option".

We don't need this change unless we were deciding to make a config option that specified a different default. That seems like overkill right now, so this doesn't need a change. Just something that I like to think about.

I also like how your tests don't just verify the backfill behavior but the ultimate behavior of 'git log' and friends after the fact.

Thanks, -Stolee

Previous: Elijah Newren via GitGitGadgetNext: Derrick Stolee
Message 7 of 8 in “Backfill fixes and edges”
  1. 0/3 Backfill fixes and edgesElijah Newren via GitGitGadget, Apr 15, 2026
  2. 1/3 backfill: reject rev-list arguments that do not make senseElijah Newren via GitGitGadget, Apr 15, 2026
  3. Derrick StoleeApr 16, 2026
  4. 2/3 backfill: document acceptance of revision-range in more standard mannerElijah Newren via GitGitGadget, Apr 15, 2026
  5. Derrick StoleeApr 16, 2026
  6. 3/3 backfill: default to grabbing edge blobs tooElijah Newren via GitGitGadget, Apr 15, 2026
  7. Derrick StoleeApr 16, 2026
  8. Derrick StoleeApr 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.