Re: [PATCH] maintenance: make unregister idempotent
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Sep 22, 2022, 19:46 UTC
- Message-ID
- <748f4e1f-f2a3-872c-2ffd-643841c454dd@github.com>
- In-Reply-To
- <xmqqtu4zxl25.fsf@gitster.g>
On 9/22/2022 3:31 PM, Junio C Hamano wrote:
Show 23 quoted lines
> Derrick Stolee <derrickstolee@github.com> writes: > >>> I am not sure if this is a good idea. What is the ultimate reason >>> why we want to allow running it blindly without knowing if it is >>> necessary? Is it because there is no easy way to tell if unregister >>> is needed in the first place? >> >> We want to leave the internal details of what it means to be >> registered as hidden to the user. They could look for the repo in >> the global config, but that seems like a hassle when they just >> want to make sure they are not currently registered. > > OK, so there is no published officially sanctioned way to ask "is > this repository under maintenance's control and cron jobs run in > it?" or "give me the list of such repositories". > > Then I can see why you want to allow users to blindly run > "unregister", with or without "--force". > > But doesn't it point at a more fundamental problem? > > Is there a reason why we want to hide the list of repositories > (enlistments?) from the users?
I don't think we want to hide it, but we've never needed to present the list in a canonical way before. It's been sufficient to let users run 'git config --global --get-all maintenance.repo', assuming they know that config key is the important one.
Adding a 'git maintenance list-registered' or something would solve that problem, but I'm not sure it is a super high priority.
Thanks, -Stolee