git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] blame: correct name of config option in docs

From
Bagas Sanjaya <bagasdotme@gmail.com>
Date
Jun 20, 2021, 09:37 UTC
Message-ID
<744f5e3e-808e-3ea1-9f3a-892c3936dcbd@gmail.com>
In-Reply-To
<20210619112912.76136-1-rybak.a.v@gmail.com>
On 19/06/21 18.29, Andrei Rybak wrote:
Show 45 quoted lines
> As can be seen in files "Documentation/blame-options.txt" and
> "builtin/blame.c", the name of this configuration option is
> "blame.markUnblamableLines".
> 
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
> 
> Thanks to Bagas Sanjaya for review.  Changes since v1:
> 
>    - tweaked commit message
> 
> Range-diff:
> 
> 1:  e32c298ee8 ! 1:  6ea64765e7 blame: fix typo in documentation
>      @@ Metadata
>       Author: Andrei Rybak <rybak.a.v@gmail.com>
>       
>        ## Commit message ##
>      -    blame: fix typo in documentation
>      +    blame: correct name of config option in docs
>       
>           As can be seen in files "Documentation/blame-options.txt" and
>      -    "builtin/blame.c", the name of this configuration variable is
>      +    "builtin/blame.c", the name of this configuration option is
>           "blame.markUnblamableLines".
>       
>           Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> 
>   Documentation/config/blame.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt
> index 9468e8599c..4d047c1790 100644
> --- a/Documentation/config/blame.txt
> +++ b/Documentation/config/blame.txt
> @@ -27,7 +27,7 @@ blame.ignoreRevsFile::
>   	file names will reset the list of ignored revisions.  This option will
>   	be handled before the command line option `--ignore-revs-file`.
>   
> -blame.markUnblamables::
> +blame.markUnblamableLines::
>   	Mark lines that were changed by an ignored revision that we could not
>   	attribute to another commit with a '*' in the output of
>   	linkgit:git-blame[1].
> 
Looks OK, thanks for contributing.
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
-- 
An old man doll... just what I always wanted! - Clara
Previous: Andrei RybakNext: Barret Rhoden
Message 7 of 16 in “blame: fix typo in documentation”
  1. blame: fix typo in documentationAndrei Rybak, Jun 18, 2021
  2. Bagas SanjayaJun 19, 2021
  3. Andrei RybakJun 19, 2021
  4. Bagas SanjayaJun 19, 2021
  5. Felipe ContrerasJun 19, 2021
  6. blame: correct name of config option in docsAndrei Rybak, Jun 19, 2021
  7. Bagas SanjayaJun 20, 2021
  8. Barret RhodenJun 21, 2021
  9. 0/3 Config option names typofixesAndrei Rybak, Jun 25, 2021
  10. 1/3 blame: correct name of config option in docsAndrei Rybak, Jun 25, 2021
  11. 2/3 t: fix typos in test messagesAndrei Rybak, Jun 25, 2021
  12. 3/3 git-worktree.txt: fix typo in example pathAndrei Rybak, Jun 25, 2021
  13. Carlo Marcelo Arenas BelónJun 26, 2021
  14. Andrei RybakJun 26, 2021
  15. Junio C HamanoJun 29, 2021
  16. Bagas SanjayaJun 26, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.