Re: [PATCH] env-helper: move this built-in to to "test-tool env-helper"

From: Andrei Rybak <rybak.a.v@gmail.com>
Date: Jan 14, 2023, 17:43 UTC
Message-ID: <744c8abe-6065-872d-8c9f-a1b1ab682d52@gmail.com>
In-Reply-To: <patch-1.1-e662c570f1d-20230112T155226Z-avarab@gmail.com>

Hi Ævar,

Here's a drive-by nitpick:

On 12/01/2023 17:03, Ævar Arnfjörð Bjarmason wrote:

Show 9 quoted lines

> diff --git a/Makefile b/Makefile
> index db447d07383..f2f342683c1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -799,6 +799,7 @@ TEST_BUILTINS_OBJS += test-dump-fsmonitor.o
>   TEST_BUILTINS_OBJS += test-dump-split-index.o
>   TEST_BUILTINS_OBJS += test-dump-untracked-cache.o
>   TEST_BUILTINS_OBJS += test-example-decorate.o
> +TEST_BUILTINS_OBJS += test-env-helper.o

The .o files are sorted alphabetically in TEST_BUILTINS_OBJS, so test-env-helper.o should be above test-example-decorate.o

Compare it to changes in t/helper/test-tool.[ch]:

Show 24 quoted lines

> diff --git a/t/helper/test-tool.c b/t/helper/test-tool.c
> index 7eb1a26a305..abe8a785eb6 100644
> --- a/t/helper/test-tool.c
> +++ b/t/helper/test-tool.c
> @@ -28,6 +28,7 @@ static struct test_cmd cmds[] = {
>   	{ "dump-fsmonitor", cmd__dump_fsmonitor },
>   	{ "dump-split-index", cmd__dump_split_index },
>   	{ "dump-untracked-cache", cmd__dump_untracked_cache },
> +	{ "env-helper", cmd__env_helper },
>   	{ "example-decorate", cmd__example_decorate },
>   	{ "fast-rebase", cmd__fast_rebase },
>   	{ "fsmonitor-client", cmd__fsmonitor_client },
> diff --git a/t/helper/test-tool.h b/t/helper/test-tool.h
> index 2e20a16eb82..ea2672436c9 100644
> --- a/t/helper/test-tool.h
> +++ b/t/helper/test-tool.h
> @@ -22,6 +22,7 @@ int cmd__dump_fsmonitor(int argc, const char **argv);
>   int cmd__dump_split_index(int argc, const char **argv);
>   int cmd__dump_untracked_cache(int argc, const char **argv);
>   int cmd__dump_reftable(int argc, const char **argv);
> +int cmd__env_helper(int argc, const char **argv);
>   int cmd__example_decorate(int argc, const char **argv);
>   int cmd__fast_rebase(int argc, const char **argv);
>   int cmd__fsmonitor_client(int argc, const char **argv);