git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] pack-objects: call release_revisions() after cruft traversal

From
Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>
Date
May 27, 2026, 15:50 UTC
Message-ID
<743adab469c748aed66555e5390379b54154216d.1779897003.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2127.git.1779897003.gitgitgadget@gmail.com>
From: Kristofer Karlsson <krka@spotify.com>

enumerate_and_traverse_cruft_objects() initializes a rev_info on the stack but never calls release_revisions() afterwards. This is not visible on master but becomes a leak once the revision walking machinery uses dynamically allocated structures.

Add the missing release_revisions() call.
Signed-off-by: Kristofer Karlsson <krka@spotify.com>
---
 builtin/pack-objects.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index 480cc0bd8c..67025e8625 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -4275,6 +4275,7 @@ static void enumerate_and_traverse_cruft_objects(struct string_list *fresh_packs
 	traverse_commit_list(&revs, show_cruft_commit, show_cruft_object, NULL);
 
 	stop_progress(&progress_state);
+	release_revisions(&revs);
 }
 
 static void read_cruft_objects(void)
-- 
gitgitgadget
Previous: Kristofer Karlsson via GitGitGadgetNext: Kristofer Karlsson via GitGitGadget
Message 2 of 4 in “revision: use priority queue for streaming walks”
  1. 0/3 revision: use priority queue for streaming walksKristofer Karlsson via GitGitGadget, May 27, 2026
  2. 1/3 pack-objects: call release_revisions() after cruft traversalKristofer Karlsson via GitGitGadget, May 27, 2026
  3. 2/3 revision: introduce rev_walk_mode to clarify get_revision_1()Kristofer Karlsson via GitGitGadget, May 27, 2026
  4. 3/3 revision: use priority queue for non-limited streaming walksKristofer Karlsson via GitGitGadget, May 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.