[PATCH 1/3] pack-objects: call release_revisions() after cruft traversal
- From
Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>
- Date
- May 27, 2026, 15:50 UTC
- Message-ID
- <743adab469c748aed66555e5390379b54154216d.1779897003.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.2127.git.1779897003.gitgitgadget@gmail.com>
From: Kristofer Karlsson <krka@spotify.com>
enumerate_and_traverse_cruft_objects() initializes a rev_info on the stack but never calls release_revisions() afterwards. This is not visible on master but becomes a leak once the revision walking machinery uses dynamically allocated structures.
Add the missing release_revisions() call.
Signed-off-by: Kristofer Karlsson <krka@spotify.com> --- builtin/pack-objects.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 480cc0bd8c..67025e8625 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -4275,6 +4275,7 @@ static void enumerate_and_traverse_cruft_objects(struct string_list *fresh_packs traverse_commit_list(&revs, show_cruft_commit, show_cruft_object, NULL); stop_progress(&progress_state); + release_revisions(&revs); } static void read_cruft_objects(void)
-- gitgitgadget