git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] git-p4: use lfs.storage instead of local .git/lfs Use lfs.storage if it defined in git.config. If lfs.storage not define - used local .git/lfs. Original code uses local .git/lfs in sync/clone operations, but if you have external lfs storage better to use it.

From
PGpanzercheg via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 4, 2019, 13:30 UTC
Message-ID
<73d0dfc9dd7e6e800297b5084de84b727e28b900.1575466209.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.483.git.1575466209.gitgitgadget@gmail.com>
From: panzercheg <panzercheg@gmail.com>
Signed-off-by: r.burenkov <panzercheg@gmail.com>
---
 git-p4.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 60c73b6a37..2bd0497c31 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1257,9 +1257,13 @@ def generatePointer(self, contentFile):
             pointerFile = re.sub(r'Git LFS pointer for.*\n\n', '', pointerFile)
 
         oid = re.search(r'^oid \w+:(\w+)', pointerFile, re.MULTILINE).group(1)
+        # if someone use external lfs.storage ( not in local repo git )
+        lfs_path = os.path.join(os.getcwd(), '.git', 'lfs')
+        if gitConfig('lfs.storage'):
+            lfs_path = gitConfig('lfs.storage')
         localLargeFile = os.path.join(
-            os.getcwd(),
-            '.git', 'lfs', 'objects', oid[:2], oid[2:4],
+            lfs_path,
+            'objects', oid[:2], oid[2:4],
             oid,
         )
         # LFS Spec states that pointer files should not have the executable bit set.
-- 
gitgitgadget
Previous: r.burenkov via GitGitGadgetNext: Junio C Hamano
Message 2 of 10 in “git-p4: use lfs.storage instead of local .git/lfs”
  1. 0/1 git-p4: use lfs.storage instead of local .git/lfsr.burenkov via GitGitGadget, Dec 4, 2019
  2. 1/1 git-p4: use lfs.storage instead of local .git/lfs Use lfs.storage if it defined in git.config. If lfs.storage not define - used local .git/lfs. Original code uses local .git/lfs in sync/clone operations, but if you have external lfs storage better to use it.panzercheg via GitGitGadget, Dec 4, 2019
  3. Junio C HamanoDec 4, 2019
  4. 0/1 git-p4: use lfs.storage instead of local .git/lfsr.burenkov via GitGitGadget, Dec 9, 2019
  5. 1/1 "git lfs" allows users to specify the custom storage location by configuration variable lfs.storage, but when "git p4" interacts with GitLFS pointers, it always used the hardcoded default that is the .git/lfs/ directory, without paying attention to the configuration.panzercheg via GitGitGadget, Dec 9, 2019
  6. Junio C HamanoDec 9, 2019
  7. Eric SunshineDec 9, 2019
  8. Johannes SchindelinDec 10, 2019
  9. Junio C HamanoDec 11, 2019
  10. Johannes SchindelinDec 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.