Re: [PATCH v4 07/12] unpack-trees: be careful around sparse directory entries

From: Derrick Stolee <stolee@gmail.com>
Date: May 28, 2021, 11:36 UTC
Message-ID: <73d09910-6d1e-014a-ff0a-931cdb71b31b@gmail.com>
In-Reply-To: <e28df7f9395da33f24d6b75fa30081074ac6b801.1621598382.git.gitgitgadget@gmail.com>

On 5/21/2021 7:59 AM, Derrick Stolee via GitGitGadget wrote:

Show 5 quoted lines

> From: Derrick Stolee <dstolee@microsoft.com>
> 
> The methods traverse_by_cache_tree() and unpack_nondirectories() have
> similar behavior in trying to demonstrate the difference between and
> index and a tree, with some differences about how they walk the index.

As I have been working on further sparse-index integrations, specifically with 'git checkout', I have found an issue with this patch that doesn't show itself in the current t1092 test script, but appears later as more complicated scenarios appear.

I am pursuing the correct fix (that will also make 'git checkout' work better) but it might be a week or two before I can send a v5 with that fix.

Thanks, -Stolee