git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH V3 0/2] specify commit by negative pattern

From
Philip Oakley <philipoakley@iee.org>
Date
Jan 10, 2016, 23:08 UTC
Message-ID
<72AF834F7D7B46D298EFE697EBF19E0E@PhilipOakley>
In-Reply-To
<1686181.AoEpo53h6D@thunderbird>
From: "Stephen & Linda Smith" <ischis2@cox.net>
Show 9 quoted lines
> On Sunday, January 10, 2016 01:25:42 PM Philip Oakley wrote:
>> From: "Stephen P. Smith" <ischis2@cox.net>
>> > Add support for negative pattern matching in  <at> ^{/<pattern>} style
>>
>> Has this become mangled by replacing the '@' with ' <at> ' ?
> It looks like the cover letter got mangled.  I will fix after I get any 
> comments
> on the patches themselves.
>

I think I was also confused between the extra ways of spelling @ (listed first in revisions.txt), and the extra was of spelling <rev>, i.e. the <rev>^{/<text>}, and then in patch 2/2 it actually being the :/<text> syntax.

Show 66 quoted lines
>>
>> When I look at the update to revisions.txt it doesn't look like its 
>> touching
>> the '@' description.
>> Is this '@^' a new (for the documenation) combination. Or has the example
>> confused me?
>>
>> > revision specifiers. So now you can find the first commit whose message
>> > doesn't match a pattern, complementing the existing positive matching.
>> > e.g.:
>> >
>> >    $ git rebase -i  <at> ^{/!-^WIP}
>> >
>> > My use-case is in having a "work, work, work, rebase, push"-style
>> > workflow, which generates a lot of "WIP foo" commits. While rebasing is
>> > usually handled via "git rebase -i origin/master", occasionally I will
>> > already have several "good, but not yet ready to push" commits hanging
>> > around while I finish work on related commits. In these situations, the
>> > ability to quickly "git diff  <at> ^{/!-^WIP}" to get an overview of 
>> > all
>> > changes "since the last one I was happy with", can be useful.
>> >
>> > This is the second version of the patch series. The previous attempt
>> > used the notation  <at> ^{/!WIP}, rather than  <at> ^{/!-WIP}, so the
>> > "modifier"
>> > was the '!' character. Now, '!' is taken as an indicator that the
>> > pattern is to be interpreted differently, and '-' is taken as an
>> > indicator of how it is to be interpreted differently. This follows
>> > recent discussion with "Junio C Hamano" <gitster <at> pobox.com> and
>> > much-less
>> > recent discussion archived at:
>> >
>> > http://thread.gmane.org/gmane.comp.version-control.git/40460/focus=40477
>> >
>> > In summary, '!' is to be used as an "escape hatch", for further
>> > extension of the "name commit by pattern" functionality. Theorised 
>> > future
>> > extensions indicated things like "what was to be searched",
>> > e.g.:  <at> ^{/!(a=author)}.  With only two interpretations of the '!'
>> > leader, for now (including the '!!' literal notation), adding such a
>> > verbose form, such as ' <at> ^{/!(negative)foo}', seemed inappropriate 
>> > at
>> > this
>> > time. In the event that such verbose forms are ever implemented, this 
>> > new
>> > form may act as a shorthand, for a basic case.
>> >
>> > Will Palmer (2):
>> >  test for '!' handling in rev-parse's named commits
>> >  object name: introduce '^{/!-<negative pattern>}' notation
>> >
>> > Documentation/revisions.txt | 11 +++++-----
>> > sha1_name.c                 | 20 ++++++++++++-----
>> > t/t1511-rev-parse-caret.sh  | 53
>> > ++++++++++++++++++++++++++++++++++++++++++++-
>> > 3 files changed, 73 insertions(+), 11 deletions(-)
>> >
>> --
>> Philip
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
Previous: Stephen & Linda SmithNext: Stephen & Linda Smith
Message 23 of 26 in “specify commit by negative pattern”
  1. 0/2 specify commit by negative patternWill Palmer, Jun 6, 2015
  2. 1/2 test for '!' handling in rev-parse's named commitsWill Palmer, Jun 6, 2015
  3. 2/2 object name: introduce '^{/!-<negative pattern>}' notationWill Palmer, Jun 6, 2015
  4. Junio C HamanoJun 8, 2015
  5. Will PalmerJun 9, 2015
  6. Junio C HamanoOct 28, 2015
  7. Stephen SmithJan 8, 2016
  8. Junio C HamanoJan 8, 2016
  9. 0/2 specify commit by negative patternStephen P. Smith, Jan 10, 2016
  10. 1/2 test for '!' handling in rev-parse's named commitsStephen P. Smith, Jan 10, 2016
  11. 2/2 object name: introduce '^{/!-<negative pattern>}' notationStephen P. Smith, Jan 10, 2016
  12. Philip OakleyJan 11, 2016
  13. 0/2 specify commit by negative patternStephen P. Smith, Jan 13, 2016
  14. 1/2 test for '!' handling in rev-parse's named commitsStephen P. Smith, Jan 13, 2016
  15. 2/2 object name: introduce '^{/!-<negative pattern>}' notationStephen P. Smith, Jan 13, 2016
  16. Junio C HamanoJan 13, 2016
  17. 2/2 object name: introduce '^{/!-<negative pattern>}' notationStephen P. Smith, Jan 31, 2016
  18. Junio C HamanoFeb 1, 2016
  19. Philip OakleyJan 10, 2016
  20. 0/2 specify commit by negative patternStephen P. Smith, Jan 11, 2016
  21. Philip OakleyJan 11, 2016
  22. Stephen & Linda SmithJan 10, 2016
  23. Philip OakleyJan 10, 2016
  24. Stephen & Linda SmithJan 9, 2016
  25. Duy NguyenJan 9, 2016
  26. Junio C HamanoJan 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.