Re: [PATCH v3 5/8] trace2: improve thread-name documentation in the thread-context
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Oct 20, 2022, 20:15 UTC
- Message-ID
- <728716c7-15e2-00f6-e249-e8bb31142d34@jeffhostetler.com>
- In-Reply-To
- <221020.86y1tafhjo.gmgdl@evledraar.gmail.com>
On 10/20/22 2:57 PM, Ævar Arnfjörð Bjarmason wrote:
Show 10 quoted lines
> > On Thu, Oct 20 2022, Jeff Hostetler via GitGitGadget wrote: > >> From: Jeff Hostetler <jeffhost@microsoft.com> >> >> Improve the documentation of the tr2tls_thread_ctx.thread_name field >> and its relation to the tr2tls_thread_ctx.thread_id field. > > Good to see this split off, thanks! >
[...]
Show 9 quoted lines
>> + * the name of the thread-proc function). For example:
>> + * { .thread_id=10, .thread_name="th10fsm-listen" }
>
> I think the example is missing a ":" after the "th10", i.e. it should be
> "th10:fsm-listen" per the code in 6/8:
>
> strbuf_addf(&buf, "th%02d:", ctx->thread_id);
> [...]
> oops. :-) good catch.
i'll fix up and resend, but will wait a bit for any other comments.
Jeff