git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] mingw: uglify (a, 0) definitions to shut up warnings

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 15, 2016, 13:24 UTC
Message-ID
<717146db7aa98d8f5e5b730b44a6fe2aae5e77a3.1452864241.git.johannes.schindelin@gmx.de>
In-Reply-To
<cover.1452864241.git.johannes.schindelin@gmx.de>

When the result of a (a, 0) expression is not used, MSys2's GCC version finds it necessary to complain with a warning:

	right-hand operand of comma expression has no effect

Let's just pretend to use the 0 value and have a peaceful and quiet life again.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 compat/nedmalloc/malloc.c.h | 3 ++-
 compat/win32/pthread.h      | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/compat/nedmalloc/malloc.c.h b/compat/nedmalloc/malloc.c.h
index f216a2a..ac0b7b4 100644
--- a/compat/nedmalloc/malloc.c.h
+++ b/compat/nedmalloc/malloc.c.h
@@ -1798,9 +1798,10 @@ struct win32_mlock_t
   volatile long threadid;
 };
 
+static inline int return_0(int i) { return 0; }
 #define MLOCK_T               struct win32_mlock_t
 #define CURRENT_THREAD        win32_getcurrentthreadid()
-#define INITIAL_LOCK(sl)      (memset(sl, 0, sizeof(MLOCK_T)), 0)
+#define INITIAL_LOCK(sl)      (memset(sl, 0, sizeof(MLOCK_T)), return_0(0))
 #define ACQUIRE_LOCK(sl)      win32_acquire_lock(sl)
 #define RELEASE_LOCK(sl)      win32_release_lock(sl)
 #define TRY_LOCK(sl)          win32_try_lock(sl)
diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
index d3dd872..20b35a2 100644
--- a/compat/win32/pthread.h
+++ b/compat/win32/pthread.h
@@ -18,7 +18,10 @@
  */
 #define pthread_mutex_t CRITICAL_SECTION
 
-#define pthread_mutex_init(a,b) (InitializeCriticalSection((a)), 0)
+static inline int return_0(int i) {
+	return 0;
+}
+#define pthread_mutex_init(a,b) return_0((InitializeCriticalSection((a)), 0))
 #define pthread_mutex_destroy(a) DeleteCriticalSection((a))
 #define pthread_mutex_lock EnterCriticalSection
 #define pthread_mutex_unlock LeaveCriticalSection
-- 
2.7.0.windows.1.7.g55a05c8
Previous: Johannes SchindelinNext: Junio C Hamano
Message 5 of 7 in “Fix compile warnings with MSys2's compiler”
  1. 0/4 Fix compile warnings with MSys2's compilerJohannes Schindelin, Jan 15, 2016
  2. 1/4 mingw: avoid redefining S_* constantsJohannes Schindelin, Jan 15, 2016
  3. 2/4 mingw: avoid warnings when casting HANDLEs to intJohannes Schindelin, Jan 15, 2016
  4. 3/4 mingw: squash another warning about a castJohannes Schindelin, Jan 15, 2016
  5. 4/4 mingw: uglify (a, 0) definitions to shut up warningsJohannes Schindelin, Jan 15, 2016
  6. Junio C HamanoJan 15, 2016
  7. Johannes SchindelinJan 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.