[PATCH v5 07/10] send-email: reduce dependancies impact on parse_address_line
- From
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>
- Date
- Jun 21, 2015, 13:02 UTC
- Message-ID
- <715613601.681945.1434891762535.JavaMail.zimbra@ensimag.grenoble-inp.fr>
- In-Reply-To
- <1692637261.3463890.1434881256090.JavaMail.zimbra@imag.fr>
Matthieu Moy <matthieu.moy@grenoble-inp.fr> writes:
> This is the last message I received in the series, and it's labeled > 07/10. Is that normal?
No, it wasn't, I have seen no error message though... I'll take a look at that later. I just sent 0008, 0009 and 0010 but I seems that I've pasted the wrong line in the in-reply-to... Maybe I need more sleep.
Show 5 quoted lines
>> We can redirect todo_output to a variable but I've not found better... >> (Maybe someone has the solution here ?). Also there's no summary at >> the end of the test (as with other perl tests). > > You can get the 1..44 at the end with
...
Show 9 quoted lines
> I would have put parse_mailbox near ident_person because both
> functions are somehow about email.
>
>> +BEGIN { use_ok('Git') }
>> +BEGIN { use_ok('Mail::Address') }
>
> This will fail if Mail::Address is not available. It would be better
> to declare Mail::Address as a prerequisite in t9000-address.sh (like
> what you're already doing for Test::More).Ok, will do.
Thanks.