Re: [PATCH v2 07/14] transport: stop needlessly copying bundle header references

From: Derrick Stolee <derrickstolee@github.com>
Date: Mar 4, 2022, 19:10 UTC
Message-ID: <70a882d2-5a57-696a-b079-ee738df57eaa@github.com>
In-Reply-To: <patch-v2-07.14-b3f7753a790-20220304T182902Z-avarab@gmail.com>

On 3/4/2022 1:32 PM, Ævar Arnfjörð Bjarmason wrote:

> Amend the logic added in fddf2ebe388 (transport: teach all vtables to
> allow fetch first, 2019-08-21) and save ourselves pointless work in
> fetch_refs_from_bundle().

Show 13 quoted lines

> -static struct ref *get_refs_from_bundle(struct transport *transport,
> -					int for_push,
> -					struct transport_ls_refs_options *transport_options)
> +static void get_refs_from_bundle_inner(struct transport *transport)
>  {
>  	struct bundle_transport_data *data = transport->data;
> -	struct ref *result = NULL;
> -	int i;
> -
> -	if (for_push)
> -		return NULL;
>  
>  	data->get_refs_from_bundle_called = 1;

The inclusion of this line dramatically changed the shape of the
diff (different areas got selected as adds and deletes) so the
range-diff looked strange, but the end result is good.
  
Thanks,
-Stolee