RE: gitk: set uicolor SystemButtonFace error on X11 if .gitk created using Win32 tk

From: Matt Seitz (matseitz) <matseitz@cisco.com>
Date: Feb 23, 2012, 19:20 UTC
Message-ID: <70952A932255A2489522275A628B97C31294E764@xmb-sjc-233.amer.cisco.com>
In-Reply-To: <CABPQNSZqX0_YAn=mOpuRquG9OzFgwS9fQ6=YXqULxMz-hbH6Zw@mail.gmail.com>

Show 5 quoted lines

> From: Erik Faye-Lund [mailto:kusmabite@gmail.com]
> 
> Are you saying that the tk shipped with recent Cygwin reports "win32"
> for "[tk windowingsystem]", but does not recognize the
> "SystemButtonFace" etc values?

Here is what I am saying:

1.  Cygwin tk 8.4.x and earlier:
-Reports "win32" for "[tk windowingsystem]"
-Recognizes the "SystemButtonFace" etc values

2.  Cygwin tk 8.5.11:
-Reports "x11" for "[tk windowingsystem]"
-Does not recognize the "SystemButtonFace" etc values

> Does this patch help?

No, this has the same problem: if gitk is installed using a tk that reports "win32" for "[tk windowingsystem]", then gitk hard codes win32 specific values into .gitk. If the user later changes to a tk that doesn't support win32 specific values, gitk will no longer work.

Two use cases:

1.  My situation:  User replaces a win32 tk with an x11 tk
2.  User uses a common .gitk file when running Windows and Linux.

Here's the error:
$ uname -a
CYGWIN_NT-5.1 matseitz-wxp 1.7.10(0.259/5/3) 2012-02-05 12:36 i686
Cygwin
$ wish
% tk windowingsystem
x11
% exit
$ gitk &
[1] 6312
$ Error in startup script: unknown color name "ButtonFace"
    while executing
"winfo rgb . $c"
    (procedure "setui" line 3)
    invoked from within
"setui $uicolor"
    (file "/usr/bin/gitk" line 11522)