pb/range-diff-with-submodule (was: Re: What's cooking in git.git (Jun 2022, #03; Fri, 10))

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Jun 11, 2022, 15:08 UTC
Message-ID: <6fc6c301-591f-7e51-f9c2-ee74f9428664@gmail.com>
In-Reply-To: <xmqqsfobc1hw.fsf@gitster.g>

Hi Junio,

Le 2022-06-10 à 23:39, Junio C Hamano a écrit :

Show 14 quoted lines

> --------------------------------------------------
> [Cooking]
> 
> * pb/range-diff-with-submodule (2022-06-06) 1 commit
>   (merged to 'next' on 2022-06-07 at e5e31590c4)
>  + range-diff: show submodule changes irrespective of diff.submodule
> 
>  "git range-diff" did not show anything for submodules that changed
>  in the ranges being compared.  Change the behaviour to include the
>  "--submodule=short" output unconditionally to be compared.
> 
>  Will merge to 'master'.
>  source: <pull.1244.v2.git.1654549153769.gitgitgadget@gmail.com>
>

As I wrote in my reply to your previous "what's cooking" [1], I think the merge message (and thus release notes blurb) for this topic could be a little more precise, something like:

"git -c diff.submodule=log range-diff" did not show anything for submodules that changed in the ranges being compared, and "git -c diff.submodule=diff range-diff" did not work correctly. Fix this by including the "--submodule=short" output unconditionally to be compared.

I was not sure if you disagreed and thus did not answer on Tuesday, or if my reply fell through the cracks, so I'm trying again.

Cheers,

Philippe.

[1] https://lore.kernel.org/git/15dd34af-14c1-5b41-5d33-a2e3b9611c25@gmail.com/