git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] git-mergetool--lib.sh: use TOOL_MODE when erroring about unknown tool

From
Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 13, 2024, 00:52 UTC
Message-ID
<6f7f553b283078ba3c81190686b150a87d901240.1731459128.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1827.git.1731459128.gitgitgadget@gmail.com>
From: Philippe Blain <levraiphilippeblain@gmail.com>

In git-mergetool--lib.sh::get_merge_tool_path, we check if the chosen tool is valid via valid_tool and exit with an error message if not. This error message mentions "Unknown merge tool", even if the command the user tried was 'git difftool --tool=unknown'. Use the global 'TOOL_MODE' variable for a more correct error message.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
 git-mergetool--lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
index 1ff26170ffc..269a60ea44c 100644
--- a/git-mergetool--lib.sh
+++ b/git-mergetool--lib.sh
@@ -474,7 +474,7 @@ get_merge_tool_path () {
 	merge_tool="$1"
 	if ! valid_tool "$merge_tool"
 	then
-		echo >&2 "Unknown merge tool $merge_tool"
+		echo >&2 "Unknown $TOOL_MODE tool $merge_tool"
 		exit 1
 	fi
 	if diff_mode
-- 
gitgitgadget
Previous: Philippe Blain via GitGitGadgetNext: Junio C Hamano
Message 3 of 20 in “git-mergetool: improve error code paths and messages”
  1. 0/5 git-mergetool: improve error code paths and messagesPhilippe Blain via GitGitGadget, Nov 13, 2024
  2. 1/5 completion: complete '--tool-help' in 'git mergetool'Philippe Blain via GitGitGadget, Nov 13, 2024
  3. 2/5 git-mergetool--lib.sh: use TOOL_MODE when erroring about unknown toolPhilippe Blain via GitGitGadget, Nov 13, 2024
  4. Junio C HamanoNov 13, 2024
  5. Philippe BlainNov 22, 2024
  6. Philippe BlainNov 22, 2024
  7. 3/5 git-mergetool--lib.sh: add error message in 'setup_user_tool'Philippe Blain via GitGitGadget, Nov 13, 2024
  8. Junio C HamanoNov 13, 2024
  9. Philippe BlainNov 22, 2024
  10. 4/5 git-mergetool--lib.sh: add error message for unknown tool variantPhilippe Blain via GitGitGadget, Nov 13, 2024
  11. Junio C HamanoNov 13, 2024
  12. Philippe BlainNov 22, 2024
  13. 5/5 git-difftool--helper.sh: exit upon initialize_merge_tool errorsPhilippe Blain via GitGitGadget, Nov 13, 2024
  14. 0/5 git-mergetool: improve error code paths and messagesPhilippe Blain via GitGitGadget, Nov 22, 2024
  15. 1/5 completion: complete '--tool-help' in 'git mergetool'Philippe Blain via GitGitGadget, Nov 22, 2024
  16. 2/5 git-mergetool--lib.sh: use TOOL_MODE when erroring about unknown toolPhilippe Blain via GitGitGadget, Nov 22, 2024
  17. 3/5 git-mergetool--lib.sh: add error message if 'setup_user_tool' failsPhilippe Blain via GitGitGadget, Nov 22, 2024
  18. 4/5 git-mergetool--lib.sh: add error message for unknown tool variantPhilippe Blain via GitGitGadget, Nov 22, 2024
  19. 5/5 git-difftool--helper.sh: exit upon initialize_merge_tool errorsPhilippe Blain via GitGitGadget, Nov 22, 2024
  20. Junio C HamanoNov 26, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.