git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] color: add support for 12-bit RGB colors

From
Beat Bolli <dev+git@drbeat.li>
Date
May 3, 2024, 19:31 UTC
Message-ID
<6f421704-774f-4069-af18-7e4b8d7b42e9@drbeat.li>
In-Reply-To
<20240503174841.GF3631237@coredump.intra.peff.net>
On 03.05.2024 19:48, Jeff King wrote:
Show 14 quoted lines
> On Thu, May 02, 2024 at 01:03:28PM +0200, Beat Bolli wrote:
> 
>>   * The color parsing code learned to handle 12-bit RGB colors.
>>
>> The first commit fixes a typo, the second one adds some test coverage
>> for invalid RGB colors, and the final one extends the RGB color parser
>> to recognize 12-bit colors, as in #f0f.
>> ---
>>
>> Changes against v1:
>> - add test coverage for invalid RGB color lengths
> 
> Ah, I missed that you had sent a new version when I responded to Junio.
> Yeah, this whole thing looks good to me!
All good ;-)
Thanks for reviewing!
Cheers, Beat
Previous: Jeff King
Message 7 of 7 in “color: add support for 12-bit RGB colors”
  1. 0/3 color: add support for 12-bit RGB colorsBeat Bolli, May 2, 2024
  2. 1/3 t/t4026-color: remove an extra double quote characterBeat Bolli, May 2, 2024
  3. 2/3 t/t4026-color: add test coverage for invalid RGB colorsBeat Bolli, May 2, 2024
  4. 3/3 color: add support for 12-bit RGB colorsBeat Bolli, May 2, 2024
  5. Junio C HamanoMay 2, 2024
  6. Jeff KingMay 3, 2024
  7. Beat BolliMay 3, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.