Re: [PATCH 2/2] name-rev: learn --format=<pretty>

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Mar 18, 2026, 15:36 UTC
Message-ID: <6eca2a08-78a9-4186-a199-c876f07415ad@app.fastmail.com>
In-Reply-To: <d3813f1d-174b-4d1b-b0c5-c6a8db260f6c@app.fastmail.com>

On Tue, Mar 17, 2026, at 23:07, Kristoffer Haugsbakk wrote:

Show 11 quoted lines

>>[snip]
>>
>> Or there may not be---I did not check, but you as the author must
>> have already checked, hence this question.
>
> This is supposed to be tested by `--name-rev --format=<pretty> with a
> note`; it has a note on the first revision but not the second.
>
> Here we never use this pointer again and we get a fresh pointer from the
> strbuf before freeing again (whether it gets populated with a pointer or
> not).

Here I meant to write: “whether it gets populated with any note data or not”.

>
> But it does sound better to just null it. There’s no need to have it
> laying around.
>[snip]