Re: [PATCH 01/23] contrib/coccinnelle: add equals-null.cocci

From: Philip Oakley <philipoakley@iee.email>
Date: Apr 30, 2022, 19:34 UTC
Message-ID: <6e8cd958-b749-0a55-d8ae-ff249f06bd2f@iee.email>
In-Reply-To: <20220430041406.164719-2-gitter.spiros@gmail.com>

On 30/04/2022 05:13, Elia Pinto wrote:

> Add a coccinelle semantic patch necessary to reinforce the git coding style
> guideline:
>
> "Do not explicitly compute an integral value with constant 0 or '\ 0', or a

s/compute/compare/

> pointer value with constant NULL."

If this gets re-rolled, perhaps include a simple example for those who don't immediately understand that quoted sentence. It will also help decode the coccinelle script

so:     `if (ptr == NULL)` becomes `if (!ptr)`  etc.

-- Philip

Show 43 quoted lines

>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
>  contrib/coccinelle/equals-null.cocci | 30 ++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 contrib/coccinelle/equals-null.cocci
>
> diff --git a/contrib/coccinelle/equals-null.cocci b/contrib/coccinelle/equals-null.cocci
> new file mode 100644
> index 0000000000..92c7054013
> --- /dev/null
> +++ b/contrib/coccinelle/equals-null.cocci
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
> +@@
> +expression e;
> +statement s;
> +@@
> +if (
> +(
> +!e
> +|
> +- e == NULL
> ++ !e
> +)
> +   )
> +   {...}
> +else s
> +
> +@@
> +expression e;
> +statement s;
> +@@
> +if (
> +(
> +e
> +|
> +- e != NULL
> ++ e
> +)
> +   )
> +   {...}
> +else s