git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/5] revision walk: optionally use sparse reachability

From
Derrick Stolee <stolee@gmail.com>
Date
Jun 24, 2019, 12:54 UTC
Message-ID
<6e726082-8275-b94e-c3d7-8899f00ea958@gmail.com>
In-Reply-To
<20190624120711.27744-3-nwf20@cl.cam.ac.uk>
On 6/24/2019 8:07 AM, Nathaniel Filardo wrote:
Show 12 quoted lines
> Add another bit flag to the struct rev_info.
> 
> The only caller that uses this after this patch is builtin/pack-objects.
> Without this, sparsity seems to do little good therein, as
> prepare_revision_walk will densely propagate UNINTERESTING flags from
> trees to tree contents, before mark_edges_uninteresting has a chance to
> be faster by being sparse.
> 
> While here, drop the "sparse" parameter to mark_edges_uninteresting,
> introduced in 4f6d26b167 ("list-objects: consume sparse tree walk",
> 2019-01-16) which can now use the flag in struct rev_info.  No
> functional change intended.

Looks like a straight-forward refactor to me. I'll keep reading for the use of this new bitflag.

-Stolee
Previous: Nathaniel FilardoNext: Nathaniel Filardo
Message 8 of 11 in “Speed up repacking when lots of pack-kept objects”
  1. 0/5 Speed up repacking when lots of pack-kept objectsNathaniel Filardo, Jun 24, 2019
  2. 4/5 repack: optionally assume transitive kept packsNathaniel Filardo, Jun 24, 2019
  3. Derrick StoleeJun 24, 2019
  4. Dr N.W. FilardoJun 25, 2019
  5. 3/5 repack: add --sparse and pass to pack-objectsNathaniel Filardo, Jun 24, 2019
  6. Derrick StoleeJun 24, 2019
  7. 2/5 revision walk: optionally use sparse reachabilityNathaniel Filardo, Jun 24, 2019
  8. Derrick StoleeJun 24, 2019
  9. 1/5 count-objects: report statistics about kept packsNathaniel Filardo, Jun 24, 2019
  10. Derrick StoleeJun 24, 2019
  11. 5/5 builtin/gc: add --assume-pack-keep-transitiveNathaniel Filardo, Jun 24, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.