git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 03/14] Change regerror() declaration from K&R style to ANSI C (C89)

From
Marius Storm-Olsen <mstormo@gmail.com>
Date
Sep 15, 2009, 13:44 UTC
Message-ID
<6e6345fb3fbc19b1a2467e33e1633fe9025e547b.1253021728.git.mstormo@gmail.com>
In-Reply-To
<26c067500d8adf17a2d75e2956e4d4a6cef27fc1.1253021728.git.mstormo@gmail.com>
From: Frank Li <lznuaa@gmail.com>

The MSVC headers typedef errcode as int, and thus confused the compiler in the K&R style definition. ANSI style deconfuses it.

Signed-off-by: Frank Li <lznuaa@gmail.com>
Signed-off-by: Marius Storm-Olsen <mstormo@gmail.com>
---
 compat/regex/regex.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/compat/regex/regex.c b/compat/regex/regex.c
index 5ea0075..67d5c37 100644
--- a/compat/regex/regex.c
+++ b/compat/regex/regex.c
@@ -4852,11 +4852,8 @@ regexec (preg, string, nmatch, pmatch, eflags)
    from either regcomp or regexec.   We don't use PREG here.  */
 
 size_t
-regerror (errcode, preg, errbuf, errbuf_size)
-    int errcode;
-    const regex_t *preg;
-    char *errbuf;
-    size_t errbuf_size;
+regerror(int errcode, const regex_t *preg,
+	 char *errbuf, size_t errbuf_size)
 {
   const char *msg;
   size_t msg_size;
-- 
1.6.2.1.418.g33d56.dirty
Previous: Marius Storm-OlsenNext: Marius Storm-Olsen
Message 4 of 21 in “Build Git with MSVC”
  1. 00/14 Build Git with MSVCMarius Storm-Olsen, Sep 15, 2009
  2. 01/14 Avoid declaration after statementMarius Storm-Olsen, Sep 15, 2009
  3. 02/14 Add define guards to compat/win32.hMarius Storm-Olsen, Sep 15, 2009
  4. 03/14 Change regerror() declaration from K&R style to ANSI C (C89)Marius Storm-Olsen, Sep 15, 2009
  5. 04/14 Set _O_BINARY as default fmode for both MinGW and MSVCMarius Storm-Olsen, Sep 15, 2009
  6. 05/14 Fix __stdcall placement and function prototypeMarius Storm-Olsen, Sep 15, 2009
  7. 06/14 Test for WIN32 instead of __MINGW32_Marius Storm-Olsen, Sep 15, 2009
  8. 07/14 Add empty header files for MSVC portMarius Storm-Olsen, Sep 15, 2009
  9. 08/14 Add MinGW header files to build git with MSVCMarius Storm-Olsen, Sep 15, 2009
  10. 09/14 Add platform files for MSVC portingMarius Storm-Olsen, Sep 15, 2009
  11. 10/14 Make usage of windows.h lean and meanMarius Storm-Olsen, Sep 15, 2009
  12. 11/14 Define strncasecmp and ftruncate for MSVCMarius Storm-Olsen, Sep 15, 2009
  13. 12/14 Add MSVC to MakefileMarius Storm-Olsen, Sep 15, 2009
  14. 13/14 Add README for MSVC buildMarius Storm-Olsen, Sep 15, 2009
  15. 14/14 Add scripts to generate projects for other buildsystems (MSVC vcproj, QMake)Marius Storm-Olsen, Sep 15, 2009
  16. Thiago FarinaSep 16, 2009
  17. Marius Storm-OlsenSep 16, 2009
  18. Alexey BorzenkovSep 15, 2009
  19. Alexey BorzenkovSep 15, 2009
  20. Alexey BorzenkovSep 15, 2009
  21. Marius Storm-OlsenSep 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.